Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only use apps from deps if cds-plugin-ui5 is present #35

Merged
merged 1 commit into from
Jan 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,12 @@ export class cds_launchpad_plugin{
// Read CDS project package
const packagejson = JSON.parse(fs.readFileSync(cds.root + '/package.json').toString());
let depsPaths = [];
try {
({ depsPaths } = this.getAppsFromDependencies(packagejson));
} catch (error) {
cdsLaunchpadLogger.error(`Error while reading dependencies: ${error}`);
if (cds.env?.plugins !== undefined && cds.env?.plugins['cds-plugin-ui5']) {
try {
({ depsPaths } = this.getAppsFromDependencies(packagejson));
} catch (error) {
cdsLaunchpadLogger.error(`Error while reading dependencies: ${error}`);
}
}

if(Array.isArray(packagejson.sapux)){
Expand Down
Loading