Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Maintain reference id on signed channel instead of the signed channel state for compatibility reasons. #11

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

holzeis
Copy link

@holzeis holzeis commented Feb 22, 2024

This would otherwise be a breaking change as new attributes can only be added trailing, without running into a DecodeError::ShortRead`

…annel state for compatibility reasons.

This would otherwise be a breaking change as new attributes can only be added trailing, without running into a DecodeError::ShortRead`
Copy link

@luckysori luckysori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@holzeis holzeis merged commit d941c82 into master Feb 22, 2024
6 of 198 checks passed
@holzeis holzeis deleted the fix/incompatible-reference-id branch February 22, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants