-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Failed to read pull request template" #5096
Comments
Thanks a lot for reporting! My initial investigation leads to this portion of the code responsible for reading the PR file from disk: gitbutler/crates/gitbutler-repo/src/commands.rs Lines 50 to 72 in d166568
It clearly assumes to receive a worktree-relative path, but I have a feeling that the PR request path is absolute. |
If you could provide the logs of a failure it should become clearer where exactly it fails, which should help to fix it 'blindly'. |
Logs
|
I get the same error. Windows. Version 0.13.0
|
Thanks a lot for the backend logs. It actually does run into the issue I thought it would run into, so we see Will investigate. |
…hs (gitbutlerapp#5096) When testing paths for prefix-matches it's important they are all normalized in the same fashion. `canonicalize()` is very particular about canonicalizing Windows paths, which makes it easy for these paths to not be compatible to other absolute-looking paths. The difficulty here is to get the right trade-off between performance and safety, e.g. we wouldn't want these canonicalized Windows paths to be used anywhere as they are very uncommon (and don't even work everywhere).
@Byron The error still happens in 0.13.1
|
Thanks a lot for reporting back! I think the source of the issue is now clearer thanks to the added context: It is due to This issue will now auto-close when #5089 is merged. |
Version
0.13.0
Operating System
Windows
Distribution Method
msi (Windows)
Describe the issue
I selected a PR template, but I get
I checked in Explorer - the file exists:
Think, this refs #4814
How to reproduce
Expected behavior
PR template is used.
Relevant log output
No response
The text was updated successfully, but these errors were encountered: