Probably fix #5096 #5111
Merged
Probably fix #5096 #5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly. Unfortunately, with anything `git2`, it's impossible (or unknown) to prevent it from picking up the users configuration, hence tests aren't isolated. This change alleviates the worst results of this which at least makes the tests run in my particular setup.
…hs (gitbutlerapp#5096) When testing paths for prefix-matches it's important they are all normalized in the same fashion. `canonicalize()` is very particular about canonicalizing Windows paths, which makes it easy for these paths to not be compatible to other absolute-looking paths. The difficulty here is to get the right trade-off between performance and safety, e.g. we wouldn't want these canonicalized Windows paths to be used anywhere as they are very uncommon (and don't even work everywhere).
|
@Byron is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
|
So what was the underlying issue here? The prefix match didn't work on windows due to canonicalize? |
|
Yes, it's very likely. Note that |
Caleb-T-Owens
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing paths for prefix-matches it's important they are all normalized in the same fashion.
canonicalize()is very particular about canonicalizing Windows paths, which makes it easy for these paths to not be compatible to other absolute-looking paths.The difficulty here is to get the right trade-off between performance and safety, e.g. we wouldn't want these canonicalized Windows paths to be used anywhere as they are very uncommon (and don't even work everywhere).
Notes for the Reviewer
read_file_from_workspace()which needs work, I just did the bare minimum here. More context is here.Related to #5096 .