Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Dockerfile for running tauri e2e tests ono mac #4643

Closed
wants to merge 15 commits into from

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Aug 7, 2024

☕️ Reasoning

  • A critical dependency for running our E2E tests, tauri-driver, is not compaitble with Mac OS. Therefore, we decided to create a linux-based container for our Mac OS-using colleagues and contributors to be able to run these tests locally

🧢 Changes

  • Adds Dockerfile
  • Some adjustments to the webdriver-io wdio.conf.ts config file to support both environments (local linux and mac OS container)

Usage

  • Build: docker build . -t gitbutler-dev-test:latest
  • Run: docker run -it -v ${PWD}:/app gitbutler-dev-test:latest from root of repo
    • Mounts in your built binary

Current Status

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
gitbutler-web ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 1:54pm

@ndom91 ndom91 changed the title feat: add Dockerfie for running tauri e2e tests ono mac feat: add Dockerfile for running tauri e2e tests on mac Aug 7, 2024
@ndom91 ndom91 changed the title feat: add Dockerfile for running tauri e2e tests on mac feat: add Dockerfile for running tauri e2e tests ono mac Aug 8, 2024
@ndom91 ndom91 force-pushed the ndom91/macos-e2e-docker-image branch from 654a865 to f9f17b5 Compare August 8, 2024 08:14
@ndom91
Copy link
Contributor Author

ndom91 commented Aug 13, 2024

@mtsgrd is this still necessary? Or does the act:test:e2e npm script suffice for you Mac folks?

@ndom91
Copy link
Contributor Author

ndom91 commented Sep 2, 2024

Closing in favor of: #4808

@ndom91
Copy link
Contributor Author

ndom91 commented Sep 2, 2024

gg

@ndom91 ndom91 closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant