-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor pr template path input to pre-filled Select
instead of TextBox
#4850
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
<Select />
instead of TextBox
<Select />
instead of TextBoxSelect
instead of TextBox
a45a5fd
to
3a26096
Compare
a6f9ad3
to
7fdbab9
Compare
29a9409
to
09b02fe
Compare
6fbaf92
to
27c03dc
Compare
a1c6704
to
ef71fcf
Compare
ef71fcf
to
e8bb66c
Compare
28210d5
to
d1d2e0c
Compare
let project = projects.get(project_id)?; | ||
let template_path = project.path.join(relative_path); | ||
|
||
Ok(read_file_from_workspace(template_path.as_path())?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talking to Nico, we've acknowledged that a path could back out of the directory using ../../../
, but due to the size of the PR, we'd rather merge in now, and improve the security in a follow up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
☕️ Reasoning
🧢 Changes
${project.path}/.github/
dir recursively<Select />
Persisted
variables to being saved on a project level in theprojects.json
createPr()
fn now. This allows reading the current setting value at time of btn click (better) and logically seems more appropriate this way.