Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename-some-things #5499

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

rename-some-things #5499

wants to merge 5 commits into from

Conversation

mtsgrd
Copy link
Contributor

@mtsgrd mtsgrd commented Nov 8, 2024 •
edited
Loading

VirtualBranch -> BranchStack
Branch -> PartialGitBranch
BranchData -> GitBranch
Branch -> BranchReference
PatchSeries -> Branch

@vercel Vercel
Copy link

vercel bot commented Nov 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 5:02pm

@github-actions github-actions bot added rust Pull requests that update Rust code @gitbutler/desktop labels Nov 8, 2024
@mtsgrd mtsgrd requested a review from krlvi November 8, 2024 15:28
krlvi
krlvi requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@krlvi krlvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of things in flight at the moment. This rename is disruptive right now, at least on the rust side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlvi krlvi krlvi requested changes

@ndom91 ndom91 ndom91 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
@gitbutler/desktop rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtsgrd @krlvi @ndom91