Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for existing fork before adding new one #5567

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Check for existing fork before adding new one #5567

merged 1 commit into from
Nov 19, 2024

Conversation

mtsgrd
Copy link
Contributor

@mtsgrd mtsgrd commented Nov 15, 2024

Adding these checks because a user reported on Discord that a remote was added twice. The root problem was pr preview being broken, but we should nonetheless prevent and show clear error messages if it happens.

  • can prevent a cascading error
  • exposes remote urls to front end

This is part 1 of 2 in a stack made with GitButler:

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 5:45pm
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 5:45pm

@github-actions github-actions bot added rust Pull requests that update Rust code @gitbutler/desktop labels Nov 15, 2024
- can prevent a cascading error
- exposes remote urls to front end
@mtsgrd mtsgrd requested a review from krlvi November 18, 2024 17:15
@mtsgrd
Copy link
Contributor Author

mtsgrd commented Nov 18, 2024

@krlvi any chance you could review this? Low impact, but good hygiene imho.

Copy link
Member

@krlvi krlvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable

@mtsgrd mtsgrd merged commit dfdffc5 into master Nov 19, 2024
20 checks passed
@mtsgrd mtsgrd deleted the mg-branch-2 branch November 19, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@gitbutler/desktop rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants