Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: File navigation in commits #5599

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix: File navigation in commits #5599

merged 1 commit into from
Nov 19, 2024

Conversation

estib-vega
Copy link
Contributor

@estib-vega estib-vega commented Nov 19, 2024

Commit files were not navigatable because the component was using an old implementation of the selection update method.

Also:

  • Remove old, now unused file selection update method
  • Add support for j, k navigation

Commit files were not navigatable because the component was using an old implementation of the selection update method.
Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 11:21am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
gitbutler-web ⬜️ Skipped (Inspect) Nov 19, 2024 11:21am

Copy link
Contributor

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; 🙌 for j and k haha

@estib-vega estib-vega merged commit bf7cce8 into master Nov 19, 2024
16 checks passed
@estib-vega estib-vega deleted the e-branch-5 branch November 19, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants