Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Warn the user when creating a PR in the middle of the stack #5600

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

estib-vega
Copy link
Contributor

When attempting to create a PR from a series that sits above another that hasn't yet been published, raise a confirmation modal

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 11:57am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
gitbutler-web ⬜️ Skipped (Inspect) Nov 19, 2024 11:57am

When attempting to create a PR from a series that sits above another that hasn't yet been published, raise a confirmation modal
Comment on lines -441 to +452
prNumber?: number | undefined;
prNumber?: number | null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important when checking:

prNumber === undefined 

Copy link
Contributor

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estib-vega estib-vega merged commit 328164c into master Nov 19, 2024
16 checks passed
@estib-vega estib-vega deleted the e-branch-6 branch November 19, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants