-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GCC for unit test mode #1393
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
6b815a5
to
c8f6c9b
Compare
Any chance this can be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR and thank you for your patience!
This "codelab" CI workflow is failing. It's because we pass the PR's branch name here to CMake over here, and it fails because that branch doesn't exist.
It doesn't exist because it's from your repo, so I guess we'd need to do with the repo the same as the branch over here.
Do you think you could fix this?
Yes! (we just need to make the CI green) |
Hi. Thank you for your response. Could you explain how I can create a branch in the google/fuzztest repo? I didn't find a way to do it |
0afd2f8
to
e2987d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
-D CMAKE_BUILD_TYPE=RelWithDebug \ | ||
-D FUZZTEST_BUILD_TESTING=on \ | ||
&& cmake --build build -j $(nproc) | ||
# TODO: Rewrite helper `PrintValue` to obtain same output under clang and gcc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aleksisch, just wanted to check if you are planning to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aleksisch, just wanted to check if you are planning to do this.
Yes, I'll investigate it
I hope this marks the start of decent GCC support ❤️ |
Official documentation says:
Right now it fails to compile.
GCC
doesn't support the flagsanitize-coverage
which is used inside fuzztest to disable (I guess) sanitizers in some internal directories.I believe we should do any of this:
GCC
(what I did in this PR).2.1 I don't know the reason behind this
sanitize-coverage=0
, maybe we can remove it.