feat(datastore): vector search #11084
Open
+452
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quartzmo
changed the title
product-auto-label
bot
added
the
api: bigtable
bhshkh
changed the title
bhshkh
force-pushed
the
feature/ds-vector-search
branch
from
882cb85
to
a78a9ec
Compare
bhshkh
force-pushed
the
feature/ds-vector-search
branch
from
a78a9ec
to
71d97e0
Compare
bhshkh
added
api: datastore
jba
approved these changes
Nov 13, 2024
| @@ -59,7 +59,9 @@ func typeMismatchReason(p Property, v reflect.Value) string { | |||
| case []byte: | |||
| entityType = "[]byte" | |||
| } | |||
|
|
|||
| if p.Meaning == 31 { | |||
| @@ -163,6 +165,12 @@ func (l *propertyLoader) loadOneElement(codec fields.List, structValue reflect.V | |||
|
|
|||
| // If the element is a slice, we need to accommodate it. | |||
| if v.Kind() == reflect.Slice && v.Type() != typeOfByteSlice { | |||
| // Check whether Vector is being loaded into appropriate field type | |||
| if field.Type != reflect.TypeOf(Vector32{}) && field.Type != reflect.TypeOf(Vector64{}) && | |||
| p.Meaning == meaningVector { | |||
There was a problem hiding this comment.
nit: it makes more sense to me if the first test is p.Meaning == meaningVector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is similar to #10548
The feature is not yet GA. This PR will be merged after GA