feat(pubsub): add otel tracing with links #9594
Conversation
…sub-otel-trace-receive-clean
…/google-cloud-go into pubsub-otel-trace-receive-clean
hongalex
changed the title
revert lang version changes to go.mod/work revert changes to go.mod fix go otel dependency versions remove unneeded changes revert renaming of ctx add clarifying comment to activeSpans map run go mod tidy commit go.sum run go mod tidy
hongalex
force-pushed
the
pubsub-otel-trace-links
branch
from
0256304
to
454e69e
Compare
pubsub/service.go
Outdated
| s := strings.Split(fqn, "/") | ||
| // Some tests don't use FQN, in which case return empty projectID. | ||
| if len(s) == 1 { | ||
| return "", s[0] |
There was a problem hiding this comment.
Is there a default project retained on the client?
There was a problem hiding this comment.
Not for tests, since we're instantiating the iterator directly via newMessageIterator We should probably change the tests to use an actual project. If that's preferred, I can make that change and remove the check here.
There was a problem hiding this comment.
If empty project for tests is a consistent idiom for pubsub it's fine for the time being, but might be good to revisit.
There was a problem hiding this comment.
It only happens once, admittedly, so not exactly an idiom. I fixed that test now, but also made this return empty strings for both if the format is not "projects/p/subscriptions/s"
pubsub/service.go
Outdated
| s := strings.Split(fqn, "/") | ||
| // Some tests don't use FQN, in which case return empty projectID. | ||
| if len(s) == 1 { | ||
| return "", s[0] |
There was a problem hiding this comment.
If empty project for tests is a consistent idiom for pubsub it's fine for the time being, but might be good to revisit.
|
@hongalex can we get another pre-release of this for testing? |
hongalex
merged commit 10826f0
into
googleapis:pubsub-otel-trace
Yeah, I created another release:
This doesn't contain changes for configuring num callbacks, but I'll update that branch to pull in changes from here as well. |
|
Thanks!
That's okay for now, we have another application where we can test the traces without needing to configure num callbacks. |
This replace #8592 and adds the missing subscribe side spans + updates the publish side spans to match our most recent design
Note: this PR uses an experimental golang.org/x/exp/slices package, which was added in go 1.21. This also depends on OpenTelemetry v1.28.0, which requires go 1.21 or higher. This PR will have failing
vet.shchecks, but should be merged into the base branch,pubsub-otel-trace. That branch instead should wait on bumping the min go version before merging.