Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(storage): update read test to use both WriteTo and Read #9666

Closed
wants to merge 1 commit into from
Closed

test(storage): update read test to use both WriteTo and Read #9666

wants to merge 1 commit into from

Conversation

BrennaEpp
Copy link
Contributor

  • This caught an io.EOF error that shouldn't be returned
  • Also removes some references to ioutil that has been deprecated

@BrennaEpp
test(storage): update read test to use both WriteTo and Read
f728cbf 
- This caught an io.EOF error that shouldn't be returned
- Also removes some references to ioutil that has been deprecated
@BrennaEpp BrennaEpp requested review from a team as code owners March 29, 2024 10:03
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Mar 29, 2024
@BrennaEpp BrennaEpp requested a review from tritone March 29, 2024 10:26
tritone
tritone reviewed Apr 3, 2024
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superceded by #9681

@tritone tritone closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone left review comments

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrennaEpp @tritone