Add support for the 'kern' table #1192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is shared in a few places, so it makes sense to have a single implementation. (It is used in the kern table, which is coming up)
This supports only the kern0 subtable type, and we should probably add a nice builder to make this a bit easier.
rsheeter
reviewed
Oct 22, 2024
| ///// The different kern subtable formats. | ||
| //format u16 KernSubtable { | ||
| //Format0(Kern0), | ||
| //// Nope. |
There was a problem hiding this comment.
lol ... explain why? Even just note we're starting simple?
There was a problem hiding this comment.
Just noticed #1183 (comment) has some good reasons, "Windows only supports format 0, and FontTools does not know of it either. FontTools also mentions a "new" Apple-specific format kern table (not subtable) with version 1.0 and completely different structures." ... should we mention 1 as well?
rsheeter
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports only the kern0 subtable type, and we should probably add a nice builder to make this a bit easier.
this is based off of #1191, which should go in first.