Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TChan documentation newBroadcastTChan example #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mhitza
Copy link

@mhitza mhitza commented Apr 23, 2020

Current example currently does not work as dupTChan runs inside the STM monad, not IO

Current example currently does not work as dupTChan runs inside the STM monad, not IO
atomically call is required for readTChan
@zoranbosnjak
Copy link

I've just noticed the same problem in the example. The proposed PR is not complete. readTChan in the same example is also STM (not IO) so it needs atomically $ ... too.

@zoranbosnjak
Copy link

Sorry, I did not see the second commit.

Copy link

@haskellGardener haskellGardener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this in the Haddocks recently. This fix is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants