[Patch] Compatibility bug when boolean compare and post requests #138
Conversation
|
Thanks, makes sense to remove "== true". But I'll need to double check the removal of the space in the body string as it caused me a lot of headaches before with different versions of ansible and ambari... |
| @@ -94,7 +94,7 @@ | |||
| user: "{{ ambari_admin_user }}" | |||
| password: "{{ ambari_admin_password }}" | |||
| headers: '{"X-Requested-By":"ambari"}' | |||
| body: "{{ cluster_blueprint|to_json }} " | |||
| body: " {{ cluster_blueprint|to_json }}" | |||
There was a problem hiding this comment.
So actually the space wasn't removed, but just moved from a trailing space to a prefixed one.
@agriffaut does this change anything?
and it's not working without space at all?
There was a problem hiding this comment.
it's not working with some specific edge cases (combinations of ambari and ansible versions), I'd like to keep that space for now unless there's proof it's causing an issue. I'll try ansible 2.5.4 but honestly ansible versions have moved since then so not really a priority. A simple fix would be to set ansible 2.6 as the required version :) https://github.com/hortonworks/ansible-hortonworks#requirements
| @@ -18,7 +18,7 @@ | |||
| backup: no | |||
| state: present | |||
| regexp: "^gpl.license.accepted.*" | |||
| line: "gpl.license.accepted={{ (accept_gpl|default(omit)|bool == true) | ternary('true', 'false') }}" | |||
| line: "gpl.license.accepted={{ accept_gpl|default(omit)|bool | ternary('true', 'false') }}" | |||
There was a problem hiding this comment.
Why not simply :
gpl.license.accepted={{ accept_gpl }}
or
gpl.license.accepted={{ accept_gpl |default('true') }}
There was a problem hiding this comment.
it covers more edge cases, not sure what you're trying to solve here...
|
@lhoss @agriffaut Is this still an issue. Does this only fix issues with old Ansible versions? Like Alex I've run into problems with those POSTs, even little extra spaces breaking things if removed. |
|
@seanorama @lhoss For me this tricky space must be kept and on the start of the string. |
|
from my side (using newer ansible version at the time, like >2.8.x) this fix wasn't really needed |
Bugs in ansible 2.5.4
Removed bad char typo