Skip to content

Commit

Permalink
BC-7347 - update to node 20 (#3497)
Browse files Browse the repository at this point in the history
  • Loading branch information
virgilchiriac authored Aug 12, 2024
1 parent 90d0106 commit 0b660ce
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: '18'
node-version: '20'

- name: setup environment and execute mocha tests
run: npm ci && npm run build && npm run mocha
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
FROM docker.io/node:18 as git
FROM docker.io/node:20 as git

RUN mkdir /app && chown -R node:node /app
WORKDIR /app
COPY .git .
RUN git config --global --add safe.directory /app && echo "{\"sha\": \"$(git rev-parse HEAD)\", \"version\": \"$(git describe --tags --abbrev=0)\", \"commitDate\": \"$(git log -1 --format=%cd --date=format:'%Y-%m-%dT%H:%M:%SZ')\", \"birthdate\": \"$(date +%Y-%m-%dT%H:%M:%SZ)\"}" > /app/version

FROM docker.io/node:18-alpine
FROM docker.io/node:20-alpine

ENV TZ=Europe/Berlin

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,16 @@
"watch": "nodemon --config nodemon.json",
"debug": "nodemon --inspect=9310 --config nodemon.json",
"debug:container": "nodemon --inspect=0.0.0.0:9310 --config nodemon.json",
"lint": "eslint --ext .json --fix . && eslint ./controllers ./helpers ./test/mocha ./api.js ./app.js ./locales --ext .js --ext .json --fix",
"lint": "eslint --ext .json --fix . && eslint ./controllers ./helpers ./test/mocha ./api.js ./app.js ./locales --ext .js --ext .json --fix",
"startd": "echo 'Do you mean 'npm run watch'?'",
"mocha": "cross-env NODE_ENV=test mocha test/mocha/ --exit --recursive",
"build": "gulp clear && cross-env NODE_OPTIONS=--openssl-legacy-provider gulp",
"dev": "gulp clear && cross-env NODE_OPTIONS=--openssl-legacy-provider gulp watch-reload",
"coverage": "nyc npm run mocha"
},
"engines": {
"node": "18",
"npm": ">=9"
"node": "20",
"npm": ">=10"
},
"lint-staged": {
"static/images/**/*.{png,jpeg,jpg,gif,svg}": [
Expand Down

0 comments on commit 0b660ce

Please sign in to comment.