Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Downloaded File Name #3043

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

PooruTorie
Copy link

@PooruTorie PooruTorie commented Dec 14, 2022

Description

Fixing the name of the downloaded file from the intern save name to the user friendly file name.
Its annoying that the downloaded file did not has the same name as displayed one.

Links to Tickets or other pull requests

#2853

Changes

I have changed the name from the "storageFileName" to the uri encoded "saveName".
The backend uses the name parameter in the content-disposition header of the download request.

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@pullapprove
Copy link

pullapprove bot commented Dec 14, 2022

Hey @NutellaJunge, thanks for the PR! The review will start once
the tests, CI checks and PR requirements (see checklist in your PR) have passed.

Copy link

sonarcloud bot commented Nov 18, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
1.1% Duplication on New Code

See analysis details on SonarCloud

@PooruTorie
Copy link
Author

Need Approving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant