Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs/heads/bc 8179 #3536

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Refs/heads/bc 8179 #3536

merged 4 commits into from
Oct 30, 2024

Conversation

atlldwp
Copy link
Contributor

@atlldwp atlldwp commented Oct 29, 2024 •
edited
Loading

Description

Links to Tickets or other pull requests

BC-8179 related.

Changes

  • Added data-testids on some elements related to the user registration process.

Data Security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@atlldwp atlldwp mentioned this pull request Oct 29, 2024
Merged
1 task
MartinSchuhmacher
MartinSchuhmacher requested changes Oct 30, 2024
View reviewed changes
views/lib/forms/paginatedForm.hbs Outdated Show resolved Hide resolved
views/registration/registration-student.hbs Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@atlldwp atlldwp merged commit d4594ec into main Oct 30, 2024
65 of 66 checks passed
@atlldwp atlldwp deleted the BC-8179 branch October 30, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinSchuhmacher MartinSchuhmacher MartinSchuhmacher approved these changes

@uidp uidp Awaiting requested review from uidp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atlldwp @MartinSchuhmacher