Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] enable test_weight_qbits_tensor_linear_cuda on xpu devices #345

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
devices += ["cuda"]
elif torch.backends.mps.is_available():
devices += ["mps"]
elif torch.xpu.is_available():
devices += ["xpu"]


@pytest.fixture(scope="module", params=devices)
Expand Down
3 changes: 3 additions & 0 deletions test/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ def get_device_memory(device):
elif device.type == "mps":
torch.mps.empty_cache()
return torch.mps.current_allocated_memory()
elif device.type == "xpu":
torch.xpu.empty_cache()
return torch.xpu.memory_allocated()
return None


Expand Down
11 changes: 8 additions & 3 deletions test/tensor/weights/test_weight_qbits_tensor_dispatch.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,20 @@ def test_weight_qbits_tensor_linear(dtype, batch_size, tokens, in_features, out_
check_weight_qtensor_linear(qbt, batch_size, tokens, use_bias)


@pytest.mark.skipif(not torch.cuda.is_available(), reason="Test is too slow on non-CUDA devices")
@pytest.mark.parametrize("dtype", [torch.float16, torch.bfloat16], ids=["fp16", "bf16"])
@pytest.mark.parametrize("batch_size", [1, 2])
@pytest.mark.parametrize("tokens", [16, 32, 48, 64])
@pytest.mark.parametrize("in_features", [1024, 4096, 16384])
@pytest.mark.parametrize("out_features", [1024, 2048, 4096])
@pytest.mark.parametrize("use_bias", [True, False], ids=["bias", "no-bias"])
def test_weight_qbits_tensor_linear_cuda(dtype, batch_size, tokens, in_features, out_features, use_bias):
device = torch.device("cuda")
def test_weight_qbits_tensor_linear_gpu(dtype, batch_size, tokens, in_features, out_features, use_bias):
if torch.cuda.is_available():
device = torch.device("cuda")
elif torch.xpu.is_available():
device = torch.device("xpu")
else:
pytest.skip(reason="Test is too slow on non-GPU devices")

weight_qtype = qint4
group_size = 128
# Create a QBitsTensor
Expand Down
2 changes: 1 addition & 1 deletion test/tensor/weights/weight_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def check_weight_qtensor_linear(qweight, batch_size, tokens, use_bias, rel_max_e
max_err = (out - qout).abs().max()
rel_max_err = max_err / mean_val
# These values were evaluated empirically without any optimized kernels.
rtol = {"cpu": 1e-2, "cuda": 2e-2, "mps": 1e-2}[device.type]
rtol = {"cpu": 1e-2, "cuda": 2e-2, "mps": 1e-2, "xpu": 2e-2}[device.type]
assert (
rel_max_err < rtol
), f"Maximum error {max_err:.2f} is too high for input of mean value {mean_val:.2f} ({rel_max_err*100:.2f} %)"