Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍃 Added Mixtral on TGI / Jetstream Pytorch #103

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Conversation

tengomucho
Copy link
Collaborator

What does this PR do?

Added support for loading and serving Mixtral models as they are supported in Jetstream Pytorch. Note, however, that serving support is limited for now, because the required memory is too big to use it in effective scenarios (for that, quantization, not supported yet, would be necessary).
A test has been added anyway.

Before submitting

  • Did you write any new necessary tests?

Note that for now serving Mixtral-8X7B is very hard due to the large
amount of resources available.
Tests are split to avoid a memory problem appearing when serving
different models in subsequent tests when using Jetstream/Pytorch.
Here we better clarify the steps of this workflow and add Mixtral test
to nightly workflow.
@tengomucho tengomucho marked this pull request as ready for review October 10, 2024 12:38
Copy link

@dacorvo dacorvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nit, otherwise LGTM, thanks !

from jetstream_pt.third_party.mixtral import config as mixtral_config
from jetstream_pt.third_party.mixtral.model import Transformer

#.model_exportable import Transformer, model_args
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a leftover from an old version that was imported from gemma model that has the same comment.

@tengomucho tengomucho merged commit 16596de into main Oct 11, 2024
3 checks passed
@tengomucho tengomucho deleted the mixtral-jetstream-pt branch October 11, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants