Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI/CD #2

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Enable CI/CD #2

merged 3 commits into from
Feb 29, 2024

Conversation

tengomucho
Copy link
Collaborator

@tengomucho tengomucho commented Feb 27, 2024

Added simple CI/CD workflow that runs TGI test on TPU.

Note that for now there are no TGI docker image tests, they will be eventually be added in a future PR.

@tengomucho tengomucho force-pushed the enable-ci-cd branch 10 times, most recently from 3afbe82 to fe733ef Compare February 28, 2024 13:34
Pytorch's RNG seems to behave differently in the docker image with
Pytorch XLA 2.3.0. This leads to different results when using
do_sample=True, so tests have been updated accordingly.
Copy link
Member

@mfuntowicz mfuntowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

[For later] The current test for TGI is purely functional right? Would be interesting to bring some tests to test batching behaviour in a few release😊

@tengomucho tengomucho merged commit b5731f7 into main Feb 29, 2024
1 check passed
@mfuntowicz mfuntowicz deleted the enable-ci-cd branch April 29, 2024 07:54
tengomucho pushed a commit that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants