IBX-7355: Allowed LIKE query conditions in Criteria for joins #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steveb-p
force-pushed
the
allow-like-queries-in-joins
branch
from
ed84532
to
854b873
Compare
Steveb-p
force-pushed
the
allow-like-queries-in-joins
branch
from
854b873
to
ff42e0b
Compare
konradoboza
approved these changes
Dec 12, 2023
| @@ -379,4 +322,67 @@ private function isInheritedColumn(string $column): bool | |||
| return $this->schemaMetadata->getIdentifierColumn() !== $column | |||
| && $this->schemaMetadata->isInheritedColumn($column); | |||
| } | |||
|
|
|||
| private function handleComparison(Comparison $comparison, Parameter $parameter, string $fullColumnName, string $placeholder): string | |||
There was a problem hiding this comment.
Arguments in separate lines for readability would be nice.
Nattfarinn
approved these changes
Dec 12, 2023
tomaszszopinski
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.6This PR allows query conditions, specifically those related to JOINed tables, to make use of
CONTAINS/STARTS_WITH/ENDS_WITHoperators, which correspond toLIKEconditions.Checklist:
$ composer fix-cs).@ibexa/php-devfor back-end changes and/or@ibexa/javascript-devforfront-end changes).