Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7782: Removed symfony/event-dispatcher-contracts direct dependency #16

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

Steveb-p
Copy link
Contributor

Question Answer
JIRA issue IBX-7782
Type bug
Target Ibexa version v4.6
BC breaks no
Doc needed no

It is not necessary for us to rely on symfony/event-dispatcher-contracts directly, as this dependency is declared by symfony/event-dispatcher itself.

Since we are not agnostic to event dispatcher implementation, we should not declare this dependency ourselves.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@Steveb-p Steveb-p added Bug Something isn't working Ready for review labels Feb 15, 2024
@Steveb-p Steveb-p merged commit 6baf1c8 into main Feb 16, 2024
11 checks passed
@Steveb-p Steveb-p deleted the ibx-7782/event-dispatcher-contracts-compatibility branch February 16, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants