Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8534: Dropped core deprecations - batch 1 #435

Merged
merged 55 commits into from
Nov 8, 2024
Merged

IBX-8534: Dropped core deprecations - batch 1 #435

merged 55 commits into from
Nov 8, 2024

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Oct 10, 2024 •
edited
Loading

@ViniTou ViniTou force-pushed the ibx-8534-core-v5-p1 branch 5 times, most recently from 4b9802e to 758439a Compare October 10, 2024 13:35
This was referenced Oct 11, 2024
Merged
Merged
Merged
Merged
@ViniTou ViniTou mentioned this pull request Oct 24, 2024
Merged
@ViniTou ViniTou force-pushed the ibx-8534-core-v5-p1 branch 2 times, most recently from 59c76c5 to 4b8c67d Compare November 4, 2024 13:37
@ViniTou ViniTou requested a review from a team November 5, 2024 10:23
adamwojs
adamwojs approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 👏

alongosz
alongosz reviewed Nov 7, 2024
View reviewed changes
src/lib/MVC/Symfony/Routing/SimplifiedRequest.php Outdated Show resolved Hide resolved
src/lib/MVC/Symfony/Routing/SimplifiedRequest.php Outdated Show resolved Hide resolved
src/lib/MVC/Symfony/Routing/SimplifiedRequest.php Show resolved Hide resolved
src/lib/MVC/Symfony/Routing/SimplifiedRequest.php Outdated Show resolved Hide resolved
src/lib/MVC/Symfony/Routing/SimplifiedRequest.php Outdated Show resolved Hide resolved
phpstan-baseline.neon Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ViniTou ViniTou requested a review from alongosz November 8, 2024 08:54
alongosz
alongosz approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note to everyone else: we'll disregard code duplication report here as it's out of scope - reporting duplication for all touched relevant files.

@alongosz alongosz merged commit aba61e9 into main Nov 8, 2024
11 of 13 checks passed
@alongosz alongosz deleted the ibx-8534-core-v5-p1 branch November 8, 2024 10:22
@adriendupuis adriendupuis mentioned this pull request Nov 15, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz alongosz approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ViniTou @adamwojs @alongosz @konradoboza @mikadamczyk @tischsoic