IBX-6312: Fixed ParentContentType View Matcher for not available parent #438
+114
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidarl
changed the title
6 tasks
vidarl
commented
Oct 17, 2024
vidarl
force-pushed
the
ibx-6312_view_matcher_ParentContentType_when_parent_is_not_available_4.6
branch
from
b0c081d
to
64aedb4
Compare
vidarl
changed the title
Steveb-p
approved these changes
Oct 21, 2024
| $this->controllerChecker | ||
| $this->controllerChecker, | ||
| false, | ||
| null |
There was a problem hiding this comment.
Nitpick: Ideally, logger calls should be checked (via Mock expectations). Missing log information would be an issue for a developer.
tbialcz
approved these changes
Nov 5, 2024
tomaszszopinski
force-pushed
the
ibx-6312_view_matcher_ParentContentType_when_parent_is_not_available_4.6
branch
from
9bd5144
to
3d8c612
Compare
tomaszszopinski
approved these changes
Nov 15, 2024
Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
…ption if parent is not available - Added test of logging
vidarl
force-pushed
the
ibx-6312_view_matcher_ParentContentType_when_parent_is_not_available_4.6
branch
from
3d8c612
to
f7437ad
Compare
|
alongosz
changed the title
alongosz
reviewed
Nov 18, 2024
Comment on lines
+11318
to
+11322
| - | ||
| message: "#^Cannot call method warning\\(\\) on Psr\\\\Log\\\\LoggerInterface\\|null\\.$#" | ||
| count: 3 | ||
| path: src/lib/MVC/Symfony/Controller/Content/PreviewController.php | ||
|
|
There was a problem hiding this comment.
This is an issue that needs to be resolved, not added to the baseline, please.
|
@vidarl Could you please rebase PR? CI has been fixed on base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3This is a rebase of ezsystems/ezplatform-kernel#383 made for 3.3. But 3.3 is now out-of-maintenance
Description:
When matcher is checking parent's contenttype, it might throw NotFoundException if the parent is not available ( for instance if it is not available in any languages configured in the current siteaccess). I don't think the matcher should throw an exception in this case, just simply return false.
In dev, this NotFoundException will be shown to the user, while this will be handled by
Ibexa\Bundle\Core\EventListener\ExceptionListenerand a non-explaining 500 will be shown:The change have no functional change on the front-end site access. User will anyway be given a 404 ( but the NotFound exception is no longer originating from the matcher). However, in admin-ui there is a big difference. A Landing page is not editable in admin-ui without the fix because the preview will be rendered with the front-end siteaccess scope and the matcher will then throw the exception
With this fix, user will see this in prod:
In dev, the preview controller will throw a BadState exception and look like this:
For QA:
See instructions in ticket for how to reproduce
Documentation:
No doc needed