Schemamigration #55
Open
Schemamigration #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghaynes
force-pushed
the
schemamigration
branch
from
28cc5d7
to
5784bc0
Compare
greghaynes
force-pushed
the
schemamigration
branch
from
5784bc0
to
5759eeb
Compare
rmoe
reviewed
Sep 20, 2017
| ''', key, value) | ||
| return SystemConfig(key, value) | ||
|
|
||
| async def get(conn, key): |
There was a problem hiding this comment.
hah, yes... how on earth is https://github.com/ibm-dev-incubator/cheeseshop/pull/55/files#diff-b08e73e3f4c0ede00de725c43853da60R11 working
There was a problem hiding this comment.
You're still providing the correct number of arguments to the method and not calling it on an instance of SystemConfig. The only difference is that by marking it a staticmethod only one copy exists. That is, SystemConfig().get is SystemConfig.get() will be True if get() is a staticmethod and False otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.