Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic support to limp along sqlite #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Basic support to limp along sqlite #184

wants to merge 1 commit into from

Conversation

bradjones1
Copy link
Contributor

No description provided.

@bradjones1 bradjones1 mentioned this pull request Dec 31, 2019
Closed
ifsnop
ifsnop reviewed Jan 1, 2020
View reviewed changes
Copy link
Owner

@ifsnop ifsnop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already now that mysql is expecting col['Field']. so I think that extractColumnName($colType) should be also in class TypeAdapterMysql, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifsnop ifsnop ifsnop left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradjones1 @ifsnop