Disallow bad pyqt5-sip versions #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can manually replay the steps of the test-w-ilastik-env action on my system and it works fine... so something off about github here I think |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
=======================================
Coverage 36.28% 36.28%
=======================================
Files 106 106
Lines 11490 11490
=======================================
Hits 4169 4169
Misses 7321 7321 ☔ View full report in Codecov by Sentry. |
These two versions cause a "Fatal Python Error. Aborted" in Github Actions with os=ubuntu-latest, reasons unknown, not reproducible on my system. Should be removed when the runner pulls something >12.13.0 that works fine by default.
k-dominik
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes nothing that could make the pipeline fail.