Fixes issue #562, multiple calls to PGBuffersArray.free() produces NullPointerException #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) produces NullPointerException
|
@JTEgan Thanks for the contribution. Can you add a test cast in |
|
Yep, will do
…On Thu, Sep 16, 2021, 11:20 PM Kevin Wooten ***@***.***> wrote:
@JTEgan <https://github.com/JTEgan> Thanks for the contribution. Can you
add a test cast in ArrayTest to verify this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#563 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFABZQA5TF5KL44TYAW2JL3UCKXYHANCNFSM5EFUZYCA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
@JTEgan Please push a new (or empty) commit to restart actions. |
|
yeah geez it's been 2 years, I gotta get around to writing that test ;-) What does it mean to |
|
The action storage has expired. So I don't know the outcome of them. A new commit (even if just empty) will re-run them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API doc for java.sql.Array says that when multiple calls are made to free(), successive calls should be a no-op. This change makes the PGBuffersArray class adhere to that spec.