-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test certs to use rsa:2048 #601
Conversation
Tests have passed 😄 |
Looks like I don't have permission to merge though |
👍 |
Permissions should be fixed |
Thanks, merged. There's another issue, couldn't deploy docs. I'll have a look when I can. |
BTW do you like to delete the branches once PR is merged to clean up? |
The usual way to do this is to use your personal fork to create the PR then there is no branch to clean up |
Hey all what's the status here. The dependency issue cropped up again with my teammate (our loophole seems to not work again). Let me know if I can help in any way to get this moving forward. Cheers. |
@davidwheeler123 Updated the dependencies in #578, there has been no release yet. |
The dependencies were updated nearly a year ago so I'll probably need to do it again - there's likely new CVEs cropped up since the last update. |
Yes please, in particular io.netty is at 4.1.109.Final now. :) |
@davidwheeler123 Thank you for pitching in... a year to get that PR 🤦♂️🤷♂️. |
As per #578 (comment) the tests are failing with an error
According to this stack overflow response the solution to this is to increase key size to 2048. That's what this PR does