Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify float, int power function #814

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Simplify float, int power function #814

merged 1 commit into from
Oct 28, 2023

Conversation

nchristensen
Copy link
Collaborator

@nchristensen nchristensen commented Oct 28, 2023 •
edited
Loading

To my eye it appears we can move the x*x outside of the if-else block and eliminate the else branch.

kaushikcfd
kaushikcfd approved these changes Oct 28, 2023
View reviewed changes
Copy link
Collaborator

@kaushikcfd kaushikcfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@inducer inducer merged commit d6a81cd into inducer:main Oct 28, 2023
16 checks passed
@inducer
Copy link
Owner

inducer commented Oct 28, 2023

Thx!

@nchristensen nchristensen deleted the simplify_pow branch October 28, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikcfd kaushikcfd kaushikcfd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nchristensen @inducer @kaushikcfd