Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nan fail test #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add nan fail test #12

wants to merge 2 commits into from

Conversation

xywei
Copy link

@xywei xywei commented Aug 4, 2020

If the expansion basis is singular at the origin, and a source point lies at the expansion center, p2e fails with NaNs.
The added test shows that this is indeed an issue with Y2DMultipoleExpansion.

cf.

@inducer
Copy link
Owner

inducer commented Aug 4, 2020

Thanks!

cc @isuruf

@isuruf
Copy link
Collaborator

isuruf commented Aug 4, 2020

HelmholtzConformingVolumeTaylorMultipoleExpansion works? H2DMultipoleExpansion will not be the default Helmholtz expansion in the near future.

@xywei
Copy link
Author

xywei commented Aug 4, 2020

HelmholtzConformingVolumeTaylorMultipoleExpansion works? H2DMultipoleExpansion will not be the default Helmholtz expansion in the near future.

I think that Taylor expansions are okay because they are smooth. The issue pertains only to basis functions that are singular (like Bessel functions of the second kind).

@inducer
Copy link
Owner

inducer commented Aug 4, 2020

I think that Taylor expansions are okay because they are smooth.

Taylor multipoles aren't smooth though. (The multipole basis consists of derivatives of the kernel.)

Base automatically changed from master to main March 8, 2021 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants