V1next history log #578
V1next history log #578
Conversation
|
Re: "committed" - this would track, in non-dev mode, if installation was attempted but failed in some way - that is, it would be set to 0 in this case and 1 if installation succeeded. The reason for the failure (probably a %Status) would be worth recording as well for a failed installation. |
This comes into the overall lifecycle rework where we flag the phase in which a module reached during install and track the error that occurred as well. For modules in dev mode, can permit resuming install from the failed phase onwards and for non-dev mode, always start from scratch for the module. |
|
Not sure why 2c240de doesn't work. I have a local registry with modA and modB, where modB depends on modA. When installing modB, IPM will call The change in commit 2c240de is simple. We create a %Persistent history log object, save it in database, and pass the ID to the work unit. In the work unit, we save the success/failure and TimeEnd. However, when calling %Save() from the spawned process, it raises the error |
|
It appears the lock is created because we're in a transaction. (Tried stepping through the code while monitoring management portal, lock disappears after manually running TCOMMIT) |
|
Here's how it currently looks like |
|
@isc-tleavitt Currently, the table data is shared among all namespaces where %IPM is mapped. Do we want to separate them? |
|
I think this is good now, just need @isc-kiyer's review |
There was a problem hiding this comment.
@isc-shuliu This is a great and exhaustive feature! My comments and some questions are up
| <parameter name="argument" required="false" description="Argument for `details` command" /> | ||
| <example description="Show history of all packages in the current namespace in descending order">history find </example> | ||
| <example description="Show history of all packages in the current namespace where command starts with "load"">history find -DCommandString="load*"</example> | ||
| <example description="Show history of all packages in the current namespace where start time is later than 2000-01-01 00:00:00">history find -DTimeStart=">2000-01-01 00:00:00"</example> |
There was a problem hiding this comment.
Rather than using -D modifiers, may be nice to be able to add sub-modifiers and enum for parameters or modifiers. Then for history, can have enum for the action parameter and sub-modifiers tied to different parameter enums. Is a bit extensive and invasive but I think it will be helpful for many other commands.
Happy to talk through design of this
| Write !, "- ", col | ||
| } | ||
| } ElseIf action = "delete" { | ||
| Do ##class(%IPM.General.History).%KillExtent() |
There was a problem hiding this comment.
For delete, should be able to filter what deletes. Such as by time or at a minimum by specific namespace. Should require passing another parameter/modifier to indicate what the scope of delete is
| /// Get the history of all installations, uninstalls, and loads in given namespace | ||
| /// The filter argument is a multidimensional array with structure | ||
| /// filter(columnName) = value | ||
| /// Where value can optionally start with >, >=, <, <=, =, <> or contain * to indicate a wildcard |
There was a problem hiding this comment.
Rather than value starting with such things, perhaps make value a $ListBuild? The possible issue with it starting with that is that the property's value may actually be using one of these symbols.
There was a problem hiding this comment.
That's a good idea, my concern is that It can be cumbersome for users to construct a command string that contains $ListBuild()s. They would need to do something like
zpm "history find -DTimeStart=" _ $lb(">", "2000-01-01 00:00:00")And I can't think of a way for it to work in interactive mode:
USER>zpm
=============================================================================
|| Welcome to the Package Manager Shell (ZPM). Version: ||
|| Enter q/quit to exit the shell. Enter ?/help to view available commands ||
|| Current registry https://pm.community.intersystems.com ||
=============================================================================
zpm:USER>history find -DTimeStart=???
Implement #366
TODO List