[IDEA] Layout attributes should be moved to a dedicated namespace to …

…prevent global namespace pollution and conflicts with other platforms (#337)

* Create draft PR for #336

* closes presentation attributes to namespaces to avoid conflicts in global space

---------

Co-authored-by: PTKu <61538034+PTKu@users.noreply.github.com>

src/AXSharp.abstractions/src/AXSharp.Abstractions/Presentation/Attributes/IgnoreRenderAttribute.cs

@@ -9,6 +9,8 @@
 using System.Collections.Generic;
 using System.Linq;
 
+namespace AXSharp.Abstractions.Presentation;
+
 public class RenderIgnoreAttribute : Attribute
 {
     private readonly IEnumerable<string> Ignorables;

src/AXSharp.abstractions/src/AXSharp.Abstractions/Presentation/Attributes/Layout/Container.cs

@@ -9,6 +9,9 @@
 using System.Linq;
 using AXSharp.Abstractions.Presentation;
 using AXSharp.Presentation.Attributes;
+
+namespace AXSharp.Abstractions.Presentation;
+
 /// <summary>
 /// Provides description of the container that shall contain the controls for data items.
 /// </summary>

src/AXSharp.abstractions/src/AXSharp.Abstractions/Presentation/Attributes/Layout/Group.cs

@@ -10,6 +10,8 @@
 using AXSharp.Abstractions.Presentation;
 using AXSharp.Presentation.Attributes;
 
+namespace AXSharp.Abstractions.Presentation;
+
 public class GroupAttribute : PresentationGroupAttribute
 {    
     /// <summary>Initializes a new instance of the <see cref="ContainerAttribute" /> class.</summary>

src/AXSharp.abstractions/src/AXSharp.Abstractions/Presentation/Attributes/Layout/GroupLayout.cs

@@ -7,6 +7,8 @@
 
 using System;
 using System.Linq;
+
+namespace AXSharp.Abstractions.Presentation;
 public enum GroupLayout
 {
     /// <summary>

src/AXSharp.abstractions/src/AXSharp.Abstractions/Presentation/Attributes/Layout/Layout.cs

@@ -7,6 +7,9 @@
 
 using System;
 using System.Linq;
+
+namespace AXSharp.Abstractions.Presentation;
+
 public enum Layout
 {
     /// <summary>

src/AXSharp.abstractions/src/AXSharp.Abstractions/Presentation/Attributes/RenderAuthorizedAttribute.cs

@@ -7,6 +7,8 @@
 
 using System;
 
+namespace AXSharp.Abstractions.Presentation;
+
 public class RenderAuthorizedAttribute : Attribute
 {
     public readonly string Permissions;

src/AXSharp.abstractions/src/AXSharp.Abstractions/Presentation/Attributes/RenderTemplateOverrideAttribute.cs

@@ -8,6 +8,9 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+
+namespace AXSharp.Abstractions.Presentation;
+
 public class RenderTemplateOverrideAttribute : Attribute
 {
 

src/AXSharp.abstractions/src/AXSharp.Abstractions/Presentation/Attributes/TimeFormatAttribute.cs

@@ -9,6 +9,8 @@
 using System.Collections.Generic;
 using System.Globalization;
 
+namespace AXSharp.Abstractions.Presentation;
+
 [AttributeUsage(AttributeTargets.Property)]
 public class TimeFormatAttribute : Attribute
 {

src/AXSharp.blazor/src/AXSharp.Presentation.Blazor/Services/AttributesHandler.cs

@@ -8,6 +8,7 @@
 using System;
 using System.Linq;
 using System.Reflection;
+using AXSharp.Abstractions.Presentation;
 using AXSharp.Connector;
 
 namespace AXSharp.Presentation.Blazor.Services

src/AXSharp.blazor/tests/sandbox/ax-blazor-example/AXSharp.config.json

@@ -1 +1 @@
-{"OutputProjectFolder":"ix","UseBase":false,"NoDependencyUpdate":false,"IgnoreS7Pragmas":false,"ProjectFile":"ax_blazor_example.csproj"}
+{"OutputProjectFolder":"ix","UseBase":false,"NoDependencyUpdate":false,"IgnoreS7Pragmas":false,"SkipDependencyCompilation":false,"ProjectFile":"ax_blazor_example.csproj"}

src/AXSharp.compiler/src/AXSharp.Cs.Compiler/Onliner/CsOnlinerSourceBuilder.cs

@@ -54,6 +54,7 @@ public void CreateFile(IFileSyntax fileSyntax, IxNodeVisitor visitor)
         AddToSource("using AXSharp.Connector.ValueTypes;");
         AddToSource("using System.Collections.Generic;");
         AddToSource("using AXSharp.Connector.Localizations;");
+        AddToSource("using AXSharp.Abstractions.Presentation;");
         foreach (var fileSyntaxUsingDirective in fileSyntax.UsingDirectives
                      .Where(p => this.Compilation.GetSemanticTree().Namespaces.Select(p => p.FullyQualifiedName).Contains(p.QualifiedIdentifierList.GetText())))
         {

src/AXSharp.compiler/src/AXSharp.Cs.Compiler/Plain/CsPlainSourceBuilder.cs

@@ -181,7 +181,8 @@ public virtual void CreateNamedValueTypeDeclaration(INamedValueTypeDeclaration n
     public void CreateFile(IFileSyntax fileSyntax, IxNodeVisitor visitor)
     {
         AddToSource("using System;");
-
+        AddToSource("using AXSharp.Abstractions.Presentation;");
+
         foreach (var fileSyntaxUsingDirective in
                  fileSyntax.UsingDirectives
                      .Where(p => this.Compilation.GetSemanticTree().Namespaces.Select(p => p.FullyQualifiedName).Contains(p.QualifiedIdentifierList.GetText())))

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/abstract_members.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 public partial class AbstractMotor : AXSharp.Connector.ITwinObject
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/array_declaration.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace ArrayDeclarationSimpleNamespace
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/class_all_primitives.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 public partial class class_all_primitives : AXSharp.Connector.ITwinObject
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/class_extended_by_known_type.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace Simatic.Ax.StateFramework
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/class_extends.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 public partial class Extended : Extendee
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/class_extends_and_implements.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 public partial class ExtendsAndImplements : ExtendeeExtendsAndImplements, IImplementation1, IImplementation2
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/class_generic_extension.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace Generics
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/class_implements.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 public partial class _NULL_CONTEXT : AXSharp.Connector.ITwinObject, IContext
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/class_implements_multiple.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 public partial class _NULL_CONTEXT_MULTIPLE : AXSharp.Connector.ITwinObject, IContext_Multiple, IObject_Multiple
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/class_internal.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 internal partial class ClassWithComplexTypes : AXSharp.Connector.ITwinObject
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/class_no_access_modifier.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 public partial class NoAccessModifierClass : AXSharp.Connector.ITwinObject
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/class_with_complex_members.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace ClassWithComplexTypesNamespace
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/class_with_non_public_members.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace ClassWithNonTraspilableMemberssNamespace
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/class_with_pragmas.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace ClassWithPragmasNamespace
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/class_with_primitive_members.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace ClassWithPrimitiveTypesNamespace
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/class_with_using_directives.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 using SimpleFirstLevelNamespace;
 using SimpleQualifiedNamespace.Qualified;
 using HelloLevelOne.HelloLevelTwo;

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/compileromitsattribute.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace CompilerOmmits
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/configuration.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 public partial class unitsTwinController : ITwinController
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/enum_simple.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 public enum Colors
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/file_with_unsupported.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace Unsupported
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/file_with_usings.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 using FileWithUsingsSimpleFirstLevelNamespace;
 using FileWithUsingsSimpleQualifiedNamespace.Qualified;
 using FileWithUsingsHelloLevelOne.FileWithUsingsHelloLevelTwo;

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/generics.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace GenericsTests
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/makereadonce.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace makereadonce
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/makereadonly.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace makereadonly
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/misc.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace Enums
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/mixed_access.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 public partial class unitsTwinController : ITwinController
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/program.g.cs

@@ -2,4 +2,5 @@
 using AXSharp.Connector;
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
-using AXSharp.Connector.Localizations;
+using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/ref_to_simple.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace RefToSimple
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/simple_empty_class.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 public partial class simple_class : AXSharp.Connector.ITwinObject
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/simple_empty_class_within_namespace.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace sampleNamespace
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/struct_simple.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 public partial class Motor : AXSharp.Connector.ITwinObject
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/type_named_values.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace NamedValuesNamespace
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/type_named_values_literals.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace Simatic.Ax.StateFramework
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/type_with_enum.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace Simatic.Ax.StateFramework
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/types_with_name_attributes.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace TypeWithNameAttributes
 {

src/AXSharp.compiler/tests/AXSharp.Compiler.CsTests/samples/units/expected/.g/Onliners/types_with_property_attributes.g.cs

@@ -3,6 +3,7 @@
 using AXSharp.Connector.ValueTypes;
 using System.Collections.Generic;
 using AXSharp.Connector.Localizations;
+using AXSharp.Abstractions.Presentation;
 
 namespace TypesWithPropertyAttributes
 {