-> Small performance improvement - Varna "line" and "radiate" now computing in parallel #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Popen(...).communicate() will wait for the subprocess to end. Therefore, "line" and "radiate" interpretations were only processed sequentially. By calling it after launching both subprocess, it allows us to run the 2 instances of VARNA RNA in parallel. ref: https://docs.python.org/3/library/subprocess.html#:~:text=Popen.communicate(input,Otherwise%2C%20it%20must%20be%20bytes.
vincbeaulieu
added a commit
to vincbeaulieu/HDV-LIG14
that referenced
this pull request
Jul 15, 2022
REASON: Maintenance interruption. COMMENTS: Improve SPOT-RNA performance (see links below): Fork: vincbeaulieu/SPOT-RNA@97ef84a Pull Request: jaswindersingh2/SPOT-RNA#24 STATUS: System is back online.
vincbeaulieu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popen(...).communicate() will wait for the subprocess to end. Therefore, "line" and "radiate" interpretations were only processed sequentially. By calling it after launching both subprocess, it allows us to run the 2 instances of VARNA RNA in parallel.
ref: https://docs.python.org/3/library/subprocess.html#:~:text=Popen.communicate(input,Otherwise%2C%20it%20must%20be%20bytes.