Fix HTTP2Test.testLargeRequestHeaders
#12536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…buffer is retained Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban
force-pushed
the
fix/jetty-12.1.x/fix-ReadOnlyBufferException-in-Mutable-Wrapper
branch
from
22b47bc
to
b9aa2bb
Compare
gregw
approved these changes
Nov 14, 2024
sbordet
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Both isFull() and space() can be lifted into the non-mutable interface RetainableByteBuffer, since they are implemented in terms of methods that exist there.
They are getter methods only that do not mutate.
By doing that, you can call these methods without the need to be mutable, and this problem would go away.
|
I'd like to see this fixed/merged soon, as it is breaking other 12.1.x PRs https://jenkins.webtide.net/blue/organizations/jenkins/jetty.project/detail/PR-12531/5/tests |
janbartel
approved these changes
Nov 15, 2024
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
sbordet
approved these changes
Nov 15, 2024
lorban
deleted the
fix/jetty-12.1.x/fix-ReadOnlyBufferException-in-Mutable-Wrapper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure
ReadOnlyBufferExceptionis not thrown from read-only methods ofRetainableByteBuffer.Mutable.Wrapper, even when the buffer is retained.This fixes such failures: https://jenkins.webtide.net/blue/organizations/jenkins/jetty.project/detail/jetty-12.1.x-ee9-ResponseTest/1/tests/