Support environmental properties to set protocol properties #374 + Review properties that can be exposed as managed properties and disallow writing to properties that don't support it #386 #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhusar
force-pushed
the
374-environmental-properties-support
branch
from
fbdc25d
to
5ad5c72
Compare
…xtras#374 Review properties that can be exposed as managed properties and disallow writing to properties that don't support it jgroups-extras#386
rhusar
force-pushed
the
374-environmental-properties-support
branch
from
5ad5c72
to
70094b2
Compare
rhusar
changed the title
|
Can I get some outside perspective e.g. from @belaban and @tristantarrant ? TLDR: result of numerous queries when people were struggling to configure these in Infinispan (especially KC since the stack is opaque to users). Lets expose this configuration as system properties as well, so people don't need to edit the stack and just pass in properties / env variables. Also, have these viewable as management. n.b. for reference belaban/JGroups#853 |
|
Not sure what you want from JGroups. It is already possible to set variables in a JGroups config. At runtime, these are searched for in system properties, then env variable, in that order. I'm not sure though if Infinispan overrides this behavior. |
pferraro
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #374
Resolve #386
Will be followed up by #390