Test case for #306 #314
Merged
Test case for #306 #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only stop voting thread if the leader elected message successfully installs new leader. * Leader is only installed if the term allows.
|
@yfei-z, many thanks for coming up with a reproducer! I've added a commit with a solution. |
|
I have updated the test, check my comments. |
|
Thanks, @yfei-z. It is reproducing the issue on my side +1 |
* Set a boolean to eventually stop the voting thread. Only interrupt in case of majority loss; * The voting thread can complete execution and then stop once the election is done.
|
@yfei-z I've added a commit with the changes I had in mind. We only interrupt the voting thread in case the majority is lost. Otherwise, we allow it to stop eventually. |
|
Seems all good! |
|
Glad to hear it, many thanks, @yfei-z! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the test case for the issue that described in #306