fix: remvoe index option from ogma options interface (#1737)

jmcdo29 · Jul 9, 2023 · 3abb979 · 3abb979
2 parents 96fa2a4 + cd6a897
commit 3abb979
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 9 deletions.
diff --git a/.changeset/gentle-eels-shave.md b/.changeset/gentle-eels-shave.md
@@ -0,0 +1,5 @@
+---
+'@ogma/nestjs-module': patch
+---
+
+Update the service options provider to correctly pass on the options to the ogma creation process
diff --git a/.changeset/loud-mice-shop.md b/.changeset/loud-mice-shop.md
@@ -0,0 +1,5 @@
+---
+'@ogma/logger': patch
+---
+
+Removed the index type from the ogma options to allow for better intellisense
diff --git a/packages/logger/src/interfaces/ogma-options.ts b/packages/logger/src/interfaces/ogma-options.ts
@@ -109,7 +109,6 @@ export interface OgmaOptions {
    * desired.
    */
   each: boolean;
-  [index: string]: any;
 }
 
 const stream = process

diff --git a/packages/nestjs-module/src/ogma.provider.ts b/packages/nestjs-module/src/ogma.provider.ts
@@ -23,7 +23,7 @@ export function createOgmaProvider(options?: Partial<OgmaOptions>): Ogma {
 }
 
 export function createOgmaServiceOptions(options: OgmaModuleOptions): OgmaModuleOptions {
-  return options.service;
+  return options;
 }
 
 export function createOgmaTraceOptions(options: OgmaModuleOptions): Lowercase<OgmaWritableLevel> {

diff --git a/packages/nestjs-module/test/ogma.provider.spec.ts b/packages/nestjs-module/test/ogma.provider.spec.ts
@@ -33,17 +33,14 @@ CreateOgmaInterceptorOptionsFactorySuite.run();
 
 const CreateOgmaServiceOptionsSuite = suite('Create Ogma Service Options');
 CreateOgmaServiceOptionsSuite('Should return the service options', () => {
-  is(createOgmaServiceOptions({ interceptor: {} }), undefined);
+  equal(createOgmaServiceOptions({}), {});
 });
 CreateOgmaServiceOptionsSuite('Should return actual options and not undefined', () => {
   equal(
     createOgmaServiceOptions({
-      interceptor: {},
-      service: {
-        json: false,
-        color: true,
-        application: 'something',
-      },
+      json: false,
+      color: true,
+      application: 'something',
     }),
     {
       color: true,