Fix several l_weights caching issues
#231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- always use highest available precision floats when caching, avoiding precision loss during dtype conversion - use `casting='same_kind'` when downcasting cached weights - fix unnecessary recalculation if `r_max` was smaller than the cached `r` - mark cached arrays as readonly to avoid cache corruption - avoid redundant copying of cached weights - use at least `r_max >= 4` while caching, to reduce the likelihood of future cache misses - add missing parameter descriptions in the `l_weights` docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
casting='same_kind'when downcasting cached weightsr_maxwas smaller than the cachedrr_max >= 4while caching, to reduce the likelihood of future cache missesl_weightsdocstringl_weightshypothesis testingl_weightscode