Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added count function #72

Merged
merged 3 commits into from
May 12, 2024
Merged

feat: added count function #72

merged 3 commits into from
May 12, 2024

Conversation

ebe25
Copy link
Contributor

@ebe25 ebe25 commented May 8, 2024

Added the count method , and this seems to be working on the www client.
@jrTilak please review, had some issues with husky, had to skip the hooks but tested them manually.

image

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lazykit-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2024 6:51am

Copy link
Owner

@jrTilak jrTilak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you efforts. Only small issues like linting and some other. Make the changes mentioned in comments and it will be ready to merge. 🚀

@jrTilak jrTilak added the seems-good This PR seems good, Now the tests will run and if everything goes well. It will be merged label May 12, 2024
@jrTilak jrTilak merged commit 8197581 into jrTilak:dev May 12, 2024
3 checks passed
@jrTilak
Copy link
Owner

jrTilak commented May 12, 2024

Thanks @ebe25 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
seems-good This PR seems good, Now the tests will run and if everything goes well. It will be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants