Validate state before ID Token request #447
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was always an ID Token request to the idP, before the state was checked.
I think it is better to perform the state check first to prevent flooding the idP with incorrect requests.
Neither the OAuth 2.0 documentation or the OpenID spec says something about checking the state before requesting the ID Token. Only that we should validate it and we do this so, that is not a problem.
Also added a test to check if the properties are set correctly on authenticate and if the code and session matches.
Needed to mock the
getState
forPHP 7.1
, looks to me like something with the session state is not working great inPHP 7.1
.PS: If you want, I can create a seperate function for the state check with the unset state so that we reuse code instead of the same duplicated state check,
PS: for the sometimes failing
invalid-bad-iat
test, would it be an option to update the301
value to302
? Or just rerun the action?List of common tasks a pull request require complete