Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solver dependent storage macro #184

Merged
merged 3 commits into from
Oct 19, 2024
Merged

Add solver dependent storage macro #184

merged 3 commits into from
Oct 19, 2024

Conversation

kaipartmann
Copy link
Owner

The macro storage(material, storage) is now extended with a macro storage(material, solver, storage). This gives the possibility to create a custom time solver that requires new fields that are not added in the general storages.

@kaipartmann kaipartmann added the enhancement New feature or request label Oct 19, 2024
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.54%. Comparing base (80b7910) to head (305a113).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/core/storages.jl 63.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
- Coverage   91.63%   91.54%   -0.09%     
==========================================
  Files          44       44              
  Lines        4258     4272      +14     
==========================================
+ Hits         3902     3911       +9     
- Misses        356      361       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaipartmann kaipartmann merged commit 737cdcc into main Oct 19, 2024
7 of 8 checks passed
@kaipartmann kaipartmann deleted the solver_dep_storage branch October 19, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant