Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update install script to install into openshift and non default namespaces #19

Merged

Conversation

Cali0707
Copy link
Collaborator

@Cali0707 Cali0707 commented Jul 4, 2024

From #10, there were a few issues with installing into openshift:

  1. Need to use s2i builder
  2. Need to have a route
  3. Need to deploy into a non default namespace
    This PR should add options for this into the deploy script

…paces

Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Copy link
Collaborator Author

Cali0707 commented Jul 4, 2024

cc @matzew

@Cali0707 Cali0707 requested a review from matzew July 4, 2024 13:51
Copy link
Collaborator

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@Cali0707 Cali0707 merged commit 5037716 into keventmesh:main Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants