Fix relocation for virtualenv>=20.26.6 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Virtualenv versions 20.26.6 and greater include a change to the activate script templates. Previously, the full path to the virtualenv that is rendered into the activation script was quoted. The newer versions render unquoted paths. The regular expressions used to match these paths now conditionally matches the quotes which should work for both old and new activation scripts.
|
venvctrl 0.8.0 seems to break the relocate feature when combined with virtualenv 20.17.1+ds (packaged by debian bookworm) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtualenv versions 20.26.6 and greater include a change to the activate script templates. Previously, the full path to the virtualenv that is rendered into the activation script was quoted. The newer versions render unquoted paths. The regular expressions used to match these paths now conditionally matches the quotes which should work for both old and new activation scripts.