Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct <li> styling and make bookmarklet search box responsive #448

Merged
merged 3 commits into from
May 13, 2024

Conversation

Meng-Heng
Copy link
Collaborator

Please review. Thank you!

@darcywong00 darcywong00 added this to the A18S1 milestone Apr 26, 2024
@mcdurdin
Copy link
Member

Could you include screenshots of before and after style? Thanks!

@mcdurdin mcdurdin added the chore label Apr 28, 2024
@Meng-Heng
Copy link
Collaborator Author

Sure!
This is the before:
image
This is the after:
image
Thank you!

bookmarklet/index.php Outdated Show resolved Hide resolved
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Just a nit question about where id's go

@Meng-Heng
Copy link
Collaborator Author

Darcy, can you test run to see if the style has been applied? No matter what I tried on my laptop, the new style didn't apply. I had to use the terminal for guidance 😄.

This is how it should look like:

  • I switch the media style to the template.css
  • Add more responsiveness to the bookmarklet-search
  • index.css has only the bookmarklet-use ol styling

screencapture-keyman-localhost-8053-bookmarklet-2024-04-30-12_16_52

@darcywong00 darcywong00 modified the milestones: A18S1, A18S2 May 11, 2024
@Meng-Heng
Copy link
Collaborator Author

Darcy, this should look good now. Should I press the merge PR?

@darcywong00
Copy link
Contributor

oh right. the sizing looked good to me. I couldn't find where the styling index.css #bookmarklet-use o got used though

@Meng-Heng
Copy link
Collaborator Author

It is being used here:
image

@darcywong00 darcywong00 merged commit 069fae8 into keymanapp:master May 13, 2024
2 checks passed
@Meng-Heng Meng-Heng deleted the bookmarklet-styling branch May 28, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants