Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-10218] Add italian translation #3822

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Conversation

gjed
Copy link
Contributor

@gjed gjed commented Jan 13, 2024

Add support for italian translation

JIRA: JBPM-10218

Referenced Pull Requests:

There is still a bit missing: the italian language does not appear in the dropdown menu in the setting page. I edited the LanguageConfigurationHandler, WorkbenchConfigurationPopup and CommonCostants classes and the gwt.xml files but something is still missing. Any advice is kindly accepted!


How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • Retest PR: jenkins retest this
  • A full downstream build: jenkins do fdb
  • A compile downstream build: jenkins do cdb
  • A full production downstream build: jenkins do product fdb
  • An upstream build: jenkins do upstream
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@gjed
Copy link
Contributor Author

gjed commented Jan 16, 2024

Rebased gjed/i18n_it on main branch

@mareknovotny
Copy link
Member

you also need to add Italian into constants and java classes which populate dropdowns ;)
see for inspiration this PR change from past https://github.com/kiegroup/kie-wb-common/pull/3191/files

@gjed
Copy link
Contributor Author

gjed commented Jan 17, 2024

you also need to add Italian into constants and java classes which populate dropdowns ;) see for inspiration this PR change from past https://github.com/kiegroup/kie-wb-common/pull/3191/files

Thanks for the answer!
I already added the option in the map of the WorkbenchConfigurationPopup and LanguageConfigurationHandler classes, added the method to the CommonConstants interface and the values in the CommonCostants*.properties are populated. (first commit 2a2a471)
That was in fact inspired on the #3191 PR.

@gjed
Copy link
Contributor Author

gjed commented Mar 7, 2024

fyi: the italian option in the language menu is present.

About the build: I'm not sure why it breaks on the org.kie.server:kie-server-services-drools:jar:7.75.0-SNAPSHOT dependency.

@mareknovotny
Copy link
Member

jenkins retest this please

Copy link

sonarcloud bot commented Mar 7, 2024

Copy link
Contributor

@pibizza pibizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a number of inline comments and reviewed almost all the files. There are a number of issues about having consistent translations - like translating or not containers and forms - but these would require a deeper review.

Updates for suggested italian translations from review

Co-authored-by: Paolo Bizzarri <pibizza@gmail.com>
@mareknovotny
Copy link
Member

jenkins retest this please

mareknovotny and others added 2 commits August 8, 2024 12:48
…rifier-reporting-client/src/main/java/org/kie/workbench/common/services/verifier/reporting/client/resources/i18n/AnalysisConstants_it.properties
Co-authored-by: Paolo Bizzarri <pibizza@gmail.com>
gjed

This comment was marked as off-topic.

@mareknovotny
Copy link
Member

jenkins retest this please

@mareknovotny mareknovotny merged commit f772331 into kiegroup:main Sep 17, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants