-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JBPM-10218] Add italian translation #3822
Conversation
Rebased gjed/i18n_it on main branch |
you also need to add Italian into constants and java classes which populate dropdowns ;) |
Thanks for the answer! |
fyi: the italian option in the language menu is present. About the build: I'm not sure why it breaks on the |
jenkins retest this please |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a number of inline comments and reviewed almost all the files. There are a number of issues about having consistent translations - like translating or not containers and forms - but these would require a deeper review.
...rg/guvnor/ala/ui/openshift/client/resources/i18n/GuvnorAlaOpenShiftUIConstants_it.properties
Outdated
Show resolved
Hide resolved
...rg/guvnor/ala/ui/openshift/client/resources/i18n/GuvnorAlaOpenShiftUIConstants_it.properties
Outdated
Show resolved
Hide resolved
.../kie/workbench/common/widgets/metadata/client/resources/i18n/MetadataConstants_it.properties
Outdated
Show resolved
Hide resolved
.../kie/workbench/common/widgets/metadata/client/resources/i18n/MetadataConstants_it.properties
Outdated
Show resolved
Hide resolved
.../kie/workbench/common/widgets/metadata/client/resources/i18n/MetadataConstants_it.properties
Outdated
Show resolved
Hide resolved
...kie/workbench/common/workbench/client/resources/i18n/DefaultWorkbenchConstants_it.properties
Outdated
Show resolved
Hide resolved
...kie/workbench/common/workbench/client/resources/i18n/DefaultWorkbenchConstants_it.properties
Outdated
Show resolved
Hide resolved
...kie/workbench/common/workbench/client/resources/i18n/DefaultWorkbenchConstants_it.properties
Outdated
Show resolved
Hide resolved
...kie/workbench/common/workbench/client/resources/i18n/DefaultWorkbenchConstants_it.properties
Outdated
Show resolved
Hide resolved
...kie/workbench/common/workbench/client/resources/i18n/DefaultWorkbenchConstants_it.properties
Outdated
Show resolved
Hide resolved
Updates for suggested italian translations from review Co-authored-by: Paolo Bizzarri <pibizza@gmail.com>
jenkins retest this please |
...nch/common/services/verifier/reporting/client/resources/i18n/AnalysisConstants_it.properties
Outdated
Show resolved
Hide resolved
…rifier-reporting-client/src/main/java/org/kie/workbench/common/services/verifier/reporting/client/resources/i18n/AnalysisConstants_it.properties
Co-authored-by: Paolo Bizzarri <pibizza@gmail.com>
jenkins retest this please |
Add support for italian translation
JIRA: JBPM-10218
Referenced Pull Requests:
There is still a bit missing: the italian language does not appear in the dropdown menu in the setting page. I edited the LanguageConfigurationHandler, WorkbenchConfigurationPopup and CommonCostants classes and the gwt.xml files but something is still missing. Any advice is kindly accepted!
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.