BugFix: Prevent crashes from tab switches due to Table Of Content #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt's WebChannel's signal JsonObject references are unreliable, so use QString for parsing. Also added guard against a potential nullptr access.
ShaopengLin
force-pushed
the
Bugfix-toc-switch-tab
branch
from
2897e7d
to
b5d3ff0
Compare
|
@kelson42 @veloman-yunkan It would be great if we could get this tested and merged in ASAP. Though at least for me it doesn't always occur, it can be very frustrating for other devs. |
|
@ShaopengLin aonce approved, I will merge and a new full testing round this WE. |
|
Just another piece of info, this issue doesn't occur in Qt6. |
veloman-yunkan
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: Crashes can happen to the TOC management when the user switches tabs. Qt's QJsonObject copies are unreliable (though they shouldn't). I am uncertain as to why, but it appears references to the copied header array elements trigger segmentation faults. It also seems to be a race condition so in some cases it doesn't happen (when I tested it before merging it never occurred).
Fixes:
tableofcontentbar.cppto prevent potential nullptr access. (This is irrelevant to the bug but something to carry over.)